Weaver Xtreme Theme Support Update

[Weaver]

A new version of Weaver Xtreme Theme Support has been released as version 6.2. This version is compatible with Weaver Xtreme Version 5.

That may seem like an odd version number, but this version corresponds to the upcoming release of Weaver Xtreme 6.2 which has some very significant changes and updates, and will require the 6.2 version of the theme support, so the plugin version 6.2 was released in preparation of the 6.2 theme release.

I will be posting the final beta release of 6.2 (which will be 6.0.9). For now, I plan to keep Weave Xtreme versioned in step with WP versions. Since WP 6.2 is in beta release now, it is possible to test compatibility, and Weaver Xtreme is compatible with WP 6.2. WP 6.2 is supposed to be releaased within a few weeks.

 

[lesatownsend]

Hi, I have a website using the Weaver Xtreme Theme Support plugin’s Youtube shortcode. That plugin is set to automatically update. Apparently, when it updated to version 6.2, it broke the Youtube shortcode functionality because now none of the videos on the site are displaying. It’s just blank where the videos should be.

Please let me know how to fix this asap. I’d be happy to simply install the older version of the plugin, if you could provide that to me.

Thanks.

[scrambler]

@weaver did find a problem with the shortcode, update to the latest 6.2.3 it should fix the issue

 

[lesatownsend]

I had already deleted the plugin and reinstalled it earlier today before coming here to the support forum. But just in case you made an update to it since then, I did it again just now. Running 6.2.3 and still no videos display.

 

[scrambler]

Can you give us the exact shortcode syntax you used and a link to the page where the shortcodes are inserted with details of where the video is supposed to be, so @weaver can have a look

[lesatownsend]

This reply has been marked as private.

[scrambler]

@weaver I did try a simple youtube shortcode with just the video ID (below) in a test page, and indeed it does not display anything

[youtube id=XeSu9fBJ2sI ]

The Youtube div is there but empty

 

[scrambler]

@lesatownsend you can download older version at the bottom of the WP advanced page below

Weaver Xtreme Theme Support (advanced view) – WordPress plugin | WordPress.org

 

[lesatownsend]

I successfully installed version 5.0.2 and the videos are displaying correctly now.

Thanks for your assistance.

[Weaver]

Sigh.

Version 6.2 works, but have some obscure bugs that turn out to not affect 99.99% of theme plugin users. (And note that these obscure bugs have been in the plugin all the way back to the first versions, so 5.0.2 is no better than 6.2 which does have some WP 6 fixes.)

But the shortcode fixes turned out to be more difficult than it seemed at first. It involved getting all the different shortcode options set up correctly, which could be incorrect in some very rare situations.

I just posted Weaver Xtreme Theme support 6.2.4 that seems to fix youtube and vimeo. I hope!

 

[lesatownsend]

I updated to 6.2.4 and the videos display correctly. Thank you so much @weaver for your hard work.

[Ned]

I also had the same problems (vimeo video not displaying) as @lesatownsend when updating from 5.0.2 to 6.2.3.

6.2.4 fixed the video not displaying problem, but added a cosmetic problem: there is now an inset border visible around the video.

I’ve made two (identical, except for plugin version) test sites to demo this.

(6.2.4, shows my video surrounded by borders) – https://reverendned.com/video-tester/

(5.0.2, shows my video with no visible borders) – https://staging3.reverendned.com/video-tester/

If there is a simple CSS fix for this, that would be good enough for me. On my live sites, I have hundreds of these vertical videos and now they all have distracting borders.

 

[hkp]

@ned

Yes, confirmed.

However, if the borders are correctly sized to the video’s displayed dimensions, then it all renders correctly.

If however the borders are over-size, then with this update, the borders will show.

[scrambler]

The border comes from the browser “user agent” CSS border-style:inset

In the older version, there is CSS coming from “Attribute style” that overrides the border to zero.

I dont think “attribute style” comes from the theme, so not sure why it is present in one case and not the other, @weaver would have to comment.

In the meantime you can fix it by adding the CSS below to the theme global Custom CSS rule box

.wvrx-video iframe {border-style:none;}

 

[hkp]

@scrambler Thanks for that rule!

I can’t get my full reply regarding videos past Wordfence, so dropped it into a file:

https://www.dropbox.com/s/6pogn3u61l4sn1y/WP%20Videos.txt?dl=0

Regards and thanks!

[Weaver]

OK, I know this has been a bit of a mess.

The main issue has been a critical need to update how the options for all 15 of the shortcodes included with the Theme Support plugin (with many options per shortcode) are processed when generating the HTML output. This issues goes back to the original theme support plugin, and is only critical when the site has users who can create posts or pages. The large number of shortcodes to fix and test made it hard to get everything right. Sorry!

All shortcode option values are now being more strictly validated to be sure an author is using valid values. As part of this process, invalid values are stripped out. So the problem with the YouTube and Vimeo short codes was a bit more interesting and unexpected. The YouTube and Vimeo embed handlers support an attribute called frameborder and have for years. It used to be considered legal HTML, but is no longer a valid parameter for the iframe HTML block used to display videos. So in the new 6.2.x version of the theme support, it turns out that the frameborder parameter was getting stripped out. As @hkp pointed out in an earlier post, if the borders are sized to match the displayed dimensions, you get a 1px border that looks fine.

So it turns out that the iframe used to display video needs an added style=”border-width:0px” to get rid of the border instead of the obsolete frameborder. So that was not easy to detect during debugging since our test code happened to work so the 1px border looked okay. In the fixed 6.2.5 version just posted, videos go back to no border.

[Author]

Posts