Home Forums Weaver Show Posts & Show Sliders .atwk-title-overlay{max-width:75%}

Topic Resolution: Resolved

This topic contains 14 replies, has 3 voices, and was last updated by  MMWBAdmin 4 months, 2 weeks ago.

Viewing 15 posts - 1 through 15 (of 15 total)
  • Author
    Posts
  • #55800

    MMWBAdmin
    Participant

    In the Weaver Slider on my homepage @ http://www.mmwb.nl the CSS is kind of wrapped in

    /*<![CDATA[*/homepslider —>    /*]]>*/

    /*<![CDATA[*/homepslider –>
    .atwkslider-homepslider .slides .atwk-slide .slide-image .atwk-title-overlay{max-width:75%}
    .atwkslider-homepslider{background-color:#fafaf5;}
    .atwkslider-homepslider .atwk-direction-nav a,.atwkslider-homepslider-thumbs .atwk-direction-nav a {background:url(https://cdn.mmwb.nl/wp-content/plugins/show-sliders/flex/images/nav-17.png) no-repeat 0 0;}.atwkslider-homepslider .atwk-direction-nav .atwk-next,.atwkslider-homepslider-thumbs .atwk-direction-nav .atwk-next {background-position: 100% 0;}
    .atwkslider-homepslider .slides .atwk-slide img{margin-top:.4em;}
    .atwkslider-homepslider .atwk-control-nav {top:102%;}/*]]>*/

    and contains  “.atwk-title-overlay{max-width:75%}” in which a semicolon is missing at the end.

    I’m not able to find where the ‘75%’-rule comes from. Hope you can help.

    Configuration info:

    ### Weaver System Info ###

    — WordPress Configuration —

    Site URL: https://www.mmwb.nl
    Home URL: https://www.mmwb.nl
    Multisite: No
    Version: 4.9.7
    Language: nl_NL
    WP_DEBUG: Enabled
    WP Memory Limit: 1024M
    Permalink: /%postname%/
    Show On Front: page
    Page On Front: Home (ID# 392)
    Page For Posts: (ID# 0)
    Current Theme: Weaver Xtreme (4.0.5)
    Post Types: post, page, attachment, revision, nav_menu_item, custom_css, customize_changeset, oembed_cache, user_request, atw_slider_post

    — Weaver Xtreme Configuration —

    Weaver Xtreme Version: 4.0.5
    Theme Support Version: 4.0.3
    Xtreme Plus Version: 3.1.1

    — Server Configuration —

    Operating System: Linux
    PHP Version: 7.2.8
    MySQL Version: 5.5.5
    jQuery Version: 1.12.4
    Server Software: Apache

    — PHP Configuration —

    Local Memory Limit: 1024M
    Server Memory Limit: 1024M
    Post Max Size: 512M
    Upload Max Filesize: 256M
    Time Limit: 300
    Max Input Vars: 5000
    Display Errors: On (1)

    — WordPress Active Plugins —

    AddToAny Share Buttons: 1.7.28
    Akismet Anti-Spam: 4.0.8
    Authy Two Factor Authentication: 3.0.2
    Block Bad Queries (BBQ): 20180511
    Cookie Notice: 1.2.44
    Custom Twitter Feeds: 1.2.9
    Dynamic Widgets: 1.5.13
    Email Address Encoder: 1.0.7
    Featured Images in RSS w/ Size and Position: 1.4.8
    Highlight Search Terms: 1.5
    jQuery Smooth Scroll: 1.4.1
    Limit Login Attempts Reloaded: 2.7.1
    Ninja Pages: 1.4.2
    Nofollow Internal Links: 1.2
    Related Posts By Taxonomy: 2.5.1
    ResponsiveVoice Text To Speech: 1.5.8
    Salt Shaker: 1.2
    Server IP & Memory Usage Display: 2.1.0
    Smush: 2.7.9.1
    TinyMCE Advanced: 4.7.11
    Ultimate Tag Cloud Widget: 2.7.2
    UpdraftPlus – Backup/Restore: 1.14.12
    W3 Total Cache: 0.9.7
    Weaver Show Posts: 1.3.15
    Weaver Show Sliders: 1.4.9
    Weaver Themes Shortcode Compatibility: 1.0.4
    Weaver Xtreme Plus: 3.1.1
    Weaver Xtreme Theme Support: 4.0.3
    Webcraftic Clearfy – WordPress optimization plugin: 1.2.1
    WP-Optimize: 2.2.4
    WP-Paginate: 2.0.4
    WP Bitly: 2.5.2
    WP External Links: 2.2.0
    Yoast SEO: 7.9

    — WordPress Inactive Plugins —

    Query Monitor: 3.1.0
    WP-Sweep: 1.0.12

    ### End System Info ###

    #55802

    Weaver
    Keymaster

    The rule is generated if you don’t include a description with the slider for proper spacing of the slider elements.

    If needed you can override it with the custom CSS included with the show slider / show posts options.

    Technically, there is no missing ‘;’. The ; is optional for the final element of rules. Some people never included it, while I almost always do. But it doesn’t matter for what is displayed.

    #55803

    MMWBAdmin
    Participant

    OK. Thanks a lot for the swift response.

    Have a nice day.

    #55816

    MMWBAdmin
    Participant

    Hi,

    still puzzles me why W3C Validator throws in an “error” for the .atwk-title-overlay selector:

    https://drive.google.com/open?id=1vplRc5DSsCmQ9muzEfmyYsmtW9NDwEkJ

    https://drive.google.com/open?id=1mtGf_N4lXMXFFQJjV6OYw1YRNPt6BZP6

    and also a CSS error

    https://drive.google.com/open?id=1_yBK02lBMK3Smr5ORXP1bIMMcWDBLEqE

    Everything works fine, nothing on red alert 😉

     

    #55819

    Weaver
    Keymaster

    I think the issue may be related to the “/*<![CDATA[*/homepslider –>” string. That is not coming from the slider plugin as far as I can find. Any idea what might be injecting that?

    #55823

    scrambler
    Moderator

    Definitely is, because if I take that chunk of CSS and remove the CDATA part it validates.

    /*<![CDATA[*/homepslider –>
    .atwkslider-homepslider .slides .atwk-slide .slide-image .atwk-title-overlay{max-width:75%}
    .atwkslider-homepslider{background-color:#fafaf5}.atwkslider-homepslider .atwk-direction-nav a,.atwkslider-homepslider-thumbs .atwk-direction-nav a{background:url(https://cdn.mmwb.nl/wp-content/plugins/show-sliders/flex/images/nav-17.png) no-repeat 0 0}
    .atwkslider-homepslider .atwk-direction-nav .atwk-next,.atwkslider-homepslider-thumbs .atwk-direction-nav .atwk-next{background-position:100% 0}
    .atwkslider-homepslider .slides .atwk-slide img{margin-top:.4em}
    .atwkslider-homepslider .atwk-control-nav{top:102%}
    /*]]>*/

    Throws an error, but the cleaned up version below does not

    .atwkslider-homepslider .slides .atwk-slide .slide-image .atwk-title-overlay{max-width:75%}
    .atwkslider-homepslider{background-color:#fafaf5}.atwkslider-homepslider .atwk-direction-nav a,.atwkslider-homepslider-thumbs .atwk-direction-nav a{background:url(https://cdn.mmwb.nl/wp-content/plugins/show-sliders/flex/images/nav-17.png) no-repeat 0 0}
    .atwkslider-homepslider .atwk-direction-nav .atwk-next,.atwkslider-homepslider-thumbs .atwk-direction-nav .atwk-next{background-position:100% 0}
    .atwkslider-homepslider .slides .atwk-slide img{margin-top:.4em}
    .atwkslider-homepslider .atwk-control-nav{top:102%}

    #55826
    Private Reply

    MMWBAdmin
    Participant
    This reply has been marked as private.
    #55827

    scrambler
    Moderator

    have you tried deactivating ALL non weaver plugins to see if the CDATA disappears?

    #55829

    scrambler
    Moderator

    Actually, the issue is not with the CDATA which is properly commented out with /*…*/

    but with the text just after homepslider –>

    @weaver, this part seems to come from the theme as it is the slider name

    looking at the style block before a slider on my test site, for a slider name gallery I see

    <!– gallery –>

    So it looks like the issue is that a piece of that has been truncated on your site and you have

    homepslider –>

    Instead of

    <!–homepslider –>

    #55830

    Weaver
    Keymaster

    The CDATA comments ARE added to JavaScript definitions, but should never be added to styles. Someone is doing that. So all the other examples you found seem to be okay since that is JavaScript.

    I’ve looked at all my examples of show_sliders, and all have the .atwk-title-overlay selector, but none have the CDATA wrapper.

    Some plugin seems to be adding that – and I don’t know why one would ever do that. Something that combines scripts or styles (W3 Total Cache?) could possibly cause, that, but it is hard to believe one like W3 could be doing considering the number of users it has.

     

    #55831

    scrambler
    Moderator

    @weaver, if you read my post above, the CDATA is not causing the error but the truncated Slider name comment tag appears to be.

    What truncates it I don’t know, but may be whatever adds the CDATA does that

    #55832

    Weaver
    Keymaster

    Ah! The plugin does inject the slider name in an HTML comment, inside a <style>. That has been there forever, and apparently has not caused actual styling issues. So somthing else is still injecting the CDATA.

    I’ll fix the name comment and release a fixed version. It is possible that some plugin is reacting badly to the incorrect HTML comment in a style block.

    #55834

    MMWBAdmin
    Participant

    OK, OK. I’m convinced. Kudos for your support!

    In short:

    the issue is that a piece of that has been truncated on your site and you have

    <b>homepslider –> </b>

    Instead of

    <b><!–homepslider –></b>

    CDATA is fine with JS but shouldn’t be in <style> .

    Not sure if I will deactivate ALL non weaver plugins (in production). Will have a closer look into this CDATA-wrapping.

    Thanks again!

    #55835

    Weaver
    Keymaster

    The fixed version of Show Sliders is posted. Just try that to see if the issue goes away because it might have been caused by the invalid conde inside a <style> block. Might be just fine now.

    #55837

    MMWBAdmin
    Participant

    Just fine now! CDATA wrapper also disappeared.

    Thanks for the solution power and the fixed version.

     

Viewing 15 posts - 1 through 15 (of 15 total)

You must be logged in to reply to this topic.