Home › Forums › Weaver Xtreme Theme › 4.3.6 breaks Page With Posts
- This topic has 12 replies, 5 voices, and was last updated 2 years, 9 months ago by Weaver.
July 28, 2020 at 01:21 UTC - Views: 50 #64931jawillParticipant
Just to let you know, Weaver Xtreme 4.3.6 theme breaks Page With Posts (template page), I’m also using latest version of Weaver Xtreme Plus (3.1.1) and Weaver Show Posts (1.5), Weaver Xtreme Theme Support (4.0.5) and Widget Shortcode (0.3.5) are also activated. Running WordPress 5.4.2. I had to reinstall back Weaver Xtreme 4.3.5. All works again with Weaver Xtreme 4.3.5July 28, 2020 at 01:48 UTC - Views: 47 #64932July 28, 2020 at 09:02 UTC - Views: 45 #64934
I encountered a problem with 4.3.6 and Page with Posts too. I had some CSS in the Xtreme plus (3.1.1) per posts CSS box which stopped working after the update and the line of CSS was displayed on the front end at the top of the content area. I moved the code to the global custom CSS and that worked OK.
Per page CSS seems to be fine on normal pages, just not on Page with Posts.July 28, 2020 at 14:29 UTC - Views: 38 #64935
I just posted 4.3.7 which should fix the issue. I did not test per post css, but will double check that.July 28, 2020 at 14:42 UTC - Views: 36 #64936
4.3.7 seems to be working correctly, I have re-instated CSS into the per page CSS box on Page with Posts and it is working as expected.
Thank you.July 28, 2020 at 14:45 UTC - Views: 38 #64937
Follow up: Per Post CSS works on my test site.
I need to apologize for the issues with Page with Posts. I had run the code through a WordPress theme validation tool which complained about how the PwP template worked. I also saw some information that the way Weaver was doing PwP was very inefficient, so I modified the PwP code to a slightly different approach to handling the loop. My own PwP test cases all seemed to work, but I missed a significant detail – no paging links.
The Page with Posts code may be the single most complicated (and convoluted) piece of code in the entire theme. The main issue is trying to fiddle around with the main “loop” for a page so that it can start a new “loop” to show the defined posts, and then resume the original page loop. Messing with the main WordPress loop is very touchy. I assumed that following the suggestions I read for nesting the loop would work and add the claimed efficiency. But my testing missed some details. So it is back to the old reliable, if perhaps slightly less efficient, method used in the past.
The [show_posts] plugin has the same issues, but was never updated to the alternate method, so it will continue to work.
Again, sorry.July 28, 2020 at 14:58 UTC - Views: 31 #64941
Thanks for the info, I understand your interest in making PwP more efficient if possible, if you don’t try these things nothing would ever be improved after all.
For me at least the problem was insignificant as I quickly found a solution by moving the CSS to global instead.
Thank you again for your very quick response, I for one really appreciate all the hard work you put into Xtreme.July 28, 2020 at 19:05 UTC - Views: 30 #64946jawillParticipant
Finally had a chance to update the website (and a blog, PwP which broke under 4.3.6) with your new 4.3.7, like a charm, all is good again! Thanks Weaver for such a fast reaction and fix!
By the way, I’m using your Weaver products, themes etc. for many years now. The Weaver X is truly the Best Fully Customizable WordPress Theme and indeed the One to Design Them All! I’ve used it on about 40 different websites. Nothing else comes close! Thanks again!
PS. Using this opportunity, I’d like also to thank Scrambler, his advice on this forum for years helped us to write better code and to make better websites! Thanks Scrambler!July 28, 2020 at 19:16 UTC - Views: 24 #64947scramblerModerator
We are welcome 🙂August 14, 2020 at 17:51 UTC - Views: 19 #65105
Can you see what i have set wrong here to get this error? i can not find any archived post settings that i may have set wrongAugust 14, 2020 at 18:10 UTC - Views: 13 #65106
i corrected it somehow. i think it was that i did not have show full posts for archives checked. Not sure. the post is showing now tho. Sorry to bother.August 14, 2020 at 18:12 UTC - Views: 9 #65107
also changed the default category for posts to specials. maybe that was it.
Still love this theme so much. Thank You!!!August 14, 2020 at 18:17 UTC - Views: 6 #65109
- You must be logged in to reply to this topic.