Home Forums Weaver Xtreme Theme 2 Column Bug in Weaver X 1.2.3?

Viewing 13 posts - 1 through 13 (of 13 total)
  • Author
    Posts
  • #17827
    Skippy
    Participant

    I just now updated my Weaver X theme. 

    Weaver Xtreme 1.2.3 Options
    – Plus (1.2.1)

    Odd formatting as I just copied the versions right out of wordpress, and now I notice my 2 column content is not forming columns, but is stacking.

    http://hesaidshesaidfortcollins.com/

    The “he said” and “she said” images were beside each other before the update.  Now they are showing “he said” on top, “she said” below it.
     
    Possible bug?  Or something else?  Maybe there is a Plus plugin update that needs to happen and simply hasn’t gotten to my site yet?

    Thanks.

    #22307
    Weaver
    Keymaster

    The 2 column styling was updated for 1.2.3, so it is possible something changed. Will look into it asap.

    #22308
    Skippy
    Participant

    Thanks much!

    #22309
    Weaver
    Keymaster

    Well, this one is HARD!

    Turns out there was a serious bug for mobile display in the 2 and 3 column blog layouts – and they use .content-2-col and .content-3-col. In your example, I can’t quite figure out why it is broken, but I don’t think I can go back to how it was. The “fix” involved how clear is being handled.

    So – content-2/3-col are really intended for the blog column settings, and it has just been good fortune so far that they worked for general usage. They don’t any more, and I don’t think I can fix this.

    There is a very easy fix – change your usage of content-2-col to content-2-col-left and content-2-col-right. There may be issues with 3 cols that will have to be addressed.

    #22310
    Skippy
    Participant

    That did fix it.

    Though if there are problems with the 3 col then I’m gonna be unhappy as I’m making a site for someone else and said person is very attached to 3 columns.  But I’ll cross that bridge when I get there.

    Thank you.

    #22311
    scrambler
    Moderator

    @weaver, it looks to me like the problem comes from an error in the nth of type rule you are using

    You have

    :nth-of-type(2n).content-2-col, :nth-of-type(3n+1).content-3-col {clear:left;}

    But I think it should be

    :nth-of-type(2n+1).content-2-col, :nth-of-type(3n+1).content-3-col {clear:left;}

    You also have the same problem with

    .is-mobile .content-3-col:nth-of-type(2n){clear:left!important}

    that should be

    .is-mobile .content-3-col:nth-of-type(2n+1){clear:left!important}

    But you are also missing the removal of the clear set in the desktop rule.

    It should actually be

    .is-mobile :nth-of-type(3n+1).content-3-col {clear:none;}
    .is-mobile .content-3-col:nth-of-type(2n+1){clear:left!important}

    #22312
    minze1
    Participant

    Will there be an update/fix for this issue ?

    I have a lot of pages with 2 or 3 columns on my site and when updating to Weaver 1.2.3 had the same problem.
    In the short term simply downgraded (if that’s the right word) to a previous version but that’s not a long term solution.
    Trying to avoid having to go through the whole site and changing pages…

    #22313
    Weaver
    Keymaster

    There will be a fix for this later this afternoon.

    There will also be an update for the Weaver Xtreme Theme Support plugin at the same time. Update the Theme Support plugin, and the new version of Weaver Xtreme will be included on the WP Dashboard Updates admin panel.

    #22314
    minze1
    Participant

    Hi Weaver

    The 2 columns seem to be working ok but I can’t get the 3 columns to work. Seems to show 1 on top and then 2 next to each other below

    Is it possible to update the tutorial at http://forum.weavertheme.com/discussion/11220/weaver-xtreme-tips-and-tutorial-part-5
    so I know what to add please ??

    #22315
    Weaver
    Keymaster

    If you are using .content-3-col directly (instead of just for blogs), you may need to wrap your <div class=”content-3-col”></div>s inside a blank <div> </div>. This is due to the way the CSS now works for these layouts.

    #22316
    minze1
    Participant

    Thank you – solved it

    #22317
    Weaver
    Keymaster

    We worked really hard yesterday to get this to work right – the main goal was to get the blog 2 and 3 column layout to work properly.

    Previous versions of Weaver Xtreme had used an entirely different method to get the columns to work, but it turned out that that method did not always work on mobile devices as expected. The problem turns out to have been lurking for a long time, but no one really figured it out until very recently.

    So the new method is to use a CSS3 property called :nth-of-type. The way CSS counts these requires that they be inside a <div> for the counting to work reliably. So in order to use these classes (.content-2-col and .content-3-col) manually, you have to wrap them all in a <div> </div>. There seems to be no nice way around this issue.

    And this also means that multiple columns will work on IE8, but may sometime have “funny” breaking points depending on the height of each column. The days of totally perfect support for IE8 are past. It is no longer worth crippling sites on modern browsers simply to keep IE8 total compatibility. Weaver Xtreme sites look very good on IE8, but will not always be “perfect”, but will degrade gracefully.

    #22318
    Weaver
    Keymaster

    @scrambler

    I updated the multiple column tutorial to reflect the need for the wrapping <div>.

Viewing 13 posts - 1 through 13 (of 13 total)
  • You must be logged in to reply to this topic.